-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support custom destination #351
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the versioning and then it's good to go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly looks good, Just clarifying two questions before approving :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Context
Closes SAP/ai-sdk-js-backlog#163.
Caution
Option 1: Do not merge until #335 is merged and custom destination is also supported in document grounding with documentation added.✔️ Option 2: Merge this PR first, then adapt #335 to support custom destination in document grounding.
With this PR, you can provide your own destination to execute any request.
For pure clients like
ai-api
, provide destination when callingexecute()
method:For
azure-openai
,orchestration
andlangchain
clients, provide destination with the constructor:Definition of Done
[ ] Error handling created / updated & covered by the tests above