Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculation views proxies #83

Closed
mvmanov opened this issue Sep 19, 2022 · 3 comments
Closed

Calculation views proxies #83

mvmanov opened this issue Sep 19, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@mvmanov
Copy link

mvmanov commented Sep 19, 2022

Hi,
I am using the inspectView command to generate a cds proxy for a calculation view. Is it possible for the proxy to be marked with the @cds.persistence.calcview and proper handle calculation view input parameters and keys? Right now all fields are marked as keys and the input parameters are ignored.

Thanks,
Milen

@jung-thomas jung-thomas added the enhancement New feature or request label Sep 19, 2022
@jung-thomas
Copy link
Contributor

There is currently no specialized logic in this tool for Calculation Views. It only reads and processes what it can learn at the SQL Level from the VIEWS API view. So, it can see the Calculation View as a Column View only. What you are describing would require going after additional Calculation View specific metadata (which might also require some different logic between HDI and Repo). But this is something we could consider in the future.

@jung-thomas jung-thomas self-assigned this Sep 19, 2022
@jung-thomas
Copy link
Contributor

I just published a first version of support for Calculation Views in inspectView. Version 3.202209.1. It will now set the annotation, keys and descriptions from the Calculation View metadata instead of the SQL Column View. It will take a little more time to add the input parameters. Maybe this Friday I can have a look at that part.

@jung-thomas
Copy link
Contributor

It took way too long to get back to this but I've finally finished this item and added support view parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants