Integration tests & Unit tests for S/4HANA business process scenario

.github/workflows/node.js.yml

@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [14.x]
+        node-version: [18.x]
         # See supported Node.js release schedule at https://nodejs.org/en/about/releases/
 
     steps:
@@ -26,6 +26,6 @@ jobs:
       with:
         node-version: ${{ matrix.node-version }}
     - run: npm install 
-    - run: npm install sqlite3
+    - run: npm install @cap-js/sqlite
     - run: npm run-script test:unit
     - run: npm run-script test:integration

db/csv/my.businessPartnerValidation-Addresses.csv

@@ -1,3 +1,4 @@
 ID;addressId;country;cityName;streetName;postalCode;notifications_ID;businessPartnerId
 58040e66-1dcd-4ffb-ab10-fdce32028b79;"124462";"DE";"Walldorf";"Dietmar-Hopp-Allee 162";"560066";2c728381-72ce-4fdd-8293-8add71579666;17100001
-64e718c9-ff99-47f1-8ca3-950c850777d4;"124463";"DE";"Walldorf";"some street";"123456";ff0bc005-710c-4097-a687-64ef380498f4;17100002
+64e718c9-ff99-47f1-8ca3-950c850777d4;"124463";"DE";"Walldorf";"some street";"123456";ff0bc005-710c-4097-a687-64ef380498f4;17100002
+64e718c9-ff99-47f1-8ca3-950c850777e5;"124464";"DE";"Walldorf";"some street";"123456";16f00c9c-323f-4ce4-876f-efaefe1c6f69;17100003

db/csv/my.businessPartnerValidation-Notifications.csv

@@ -1,3 +1,4 @@
 ID;businessPartnerId;businessPartnerName;verificationStatus_code
 2c728381-72ce-4fdd-8293-8add71579666;17100001;TestData1;N
-ff0bc005-710c-4097-a687-64ef380498f4;17100002;TestData2;P
+ff0bc005-710c-4097-a687-64ef380498f4;17100002;TestData2;P
+16f00c9c-323f-4ce4-876f-efaefe1c6f69;17100003;TestData3;P

package.json

@@ -19,10 +19,10 @@
     },
     "scripts": {
         "start": "npx cds-serve",
-        "test": "npm install @cap-js/sqlite && npm run test:integration",
-        "test:integration": "mocha tests/mocha.test.js --timeout 28000",
+        "test": "npm run test:integration",
+        "test:integration": "jest tests/integration/BPValidation.test.js",
         "test:unit": "jest tests/unit/service.test.js",
-        "test:legacy": "mocha tests/chai-test.js --timeout 15000 --exit"
+        "test:legacy": "mocha tests/legacy/chai-test.js --timeout 15000 --exit"
     },
     "devDependencies": {
         "@cap-js/sqlite": "^1.1.0",

srv/service.js

@@ -69,12 +69,16 @@ const cds = require('@sap/cds');
         req.data.isModified = true;
       });
 
-      srv.after("PATCH", "Addresses", (data, req) => {
-        const isValidPinCode = postcodeValidator(data.postalCode, data.country);
-        if(!isValidPinCode){
-          return req.error({code: '400', message: "invalid postal code", numericSeverity:2, target: 'postalCode'});
-        } 
-        return req.info({numericSeverity:1, target: 'postalCode'});  
+      srv.after("PATCH", "Addresses", async (data, req) => {
+        srv.LOG.info("Received address in PATCH", data);
+        let isValidPinCode = true;
+        if(data && data.postalCode){
+          isValidPinCode = await this.validatePostcode(data, this.LOG);
+        }
+
+        if(!isValidPinCode) {
+          return req.error({ code: '400', message: "invalid postal code", numericSeverity: 2, target: 'postalCode' });
+        }
       });
 
       await super.init()
@@ -90,19 +94,41 @@ const cds = require('@sap/cds');
       }
     }
 
+    async validatePostcode(data, LOG){
+      const {Addresses} = this.entities;
+      const {postcodeValidator} = require('postcode-validator');
+      let isValidPinCode;
+      if(data.postalCode){
+        const address = await cds.run(SELECT.one(Addresses).where({ ID: data.ID }));
+        isValidPinCode = postcodeValidator(data.postalCode, address.country);
+        LOG.info("isValidPinCode ",isValidPinCode);
+        return isValidPinCode;
+      }
+    }
+
   async emitEvent(bupaSrv, result, LOG){
-    const {BusinessPartner, BusinessPartnerAddress} = this.entities;
-    const resultJoin =  await cds.run(SELECT.one("my.businessPartnerValidation.Notifications as N").leftJoin("my.businessPartnerValidation.Addresses as A").on("N.businessPartnerId = A.businessPartnerId").where({"N.ID": result.ID}));
+    const {BusinessPartner, BusinessPartnerAddress, Notifications} = this.entities;
+    const resultJoin = await cds.run(
+      SELECT.one(Notifications, notification => {
+          notification('*'),
+          notification.addresses((addresses) => {
+              addresses('*')
+            });
+        })
+        .where({"ID": result.ID})
+    )
+
+    const addressResult = resultJoin.addresses[0];
     const statusValues={"N":"NEW", "P":"PROCESS", "INV":"INVALID", "V":"VERIFIED"}
 
-    if(resultJoin.isModified){
+    if(addressResult.isModified){
       let payload = {
-        streetName: resultJoin.streetName,
-        postalCode: resultJoin.postalCode
+        streetName: addressResult.streetName,
+        postalCode: addressResult.postalCode
       }
 
       LOG.info("<<<<payload address", payload)
-      let res = await bupaSrv.run(UPDATE(BusinessPartnerAddress).set(payload).where({businessPartnerId:resultJoin.businessPartnerId, addressId:resultJoin.addressId}));
+      let res = await bupaSrv.run(UPDATE(BusinessPartnerAddress).set(payload).where({businessPartnerId:resultJoin.businessPartnerId, addressId:addressResult.addressId}));
 
       LOG.info(`address update to S/4 Backend system`, res);
     }