Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Pin platform for Mac M1/M2 support #495

Merged
merged 2 commits into from
Apr 26, 2023
Merged

Pin platform for Mac M1/M2 support #495

merged 2 commits into from
Apr 26, 2023

Conversation

ublock
Copy link
Contributor

@ublock ublock commented Apr 25, 2023

Purpose

By using a fixed platform the image runs on Mac M1/2 laptops.

Does the PR solve an issue

Not a tracked one

Does this introduce a breaking change?

Hopefully not. But I have not been able to test it on other OS and platforms.

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@ublock ublock requested a review from lechnerc77 April 25, 2023 13:47
@cla-assistant
Copy link

cla-assistant bot commented Apr 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ublock ublock requested a review from rui1610 April 25, 2023 15:01
@lechnerc77 lechnerc77 changed the base branch from main to dev April 25, 2023 15:05
lechnerc77
lechnerc77 reviewed Apr 26, 2023
View reviewed changes
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lechnerc77
Copy link
Member

Will execute integration test, once we have a free slot

@lechnerc77 lechnerc77 added this to the to be planned milestone Apr 26, 2023
@lechnerc77 lechnerc77 added the bug Something isn't working label Apr 26, 2023
@lechnerc77
Copy link
Member

Run successful: https://github.com/SAP-samples/btp-setup-automator/actions/runs/4806936933

@lechnerc77 lechnerc77 merged commit 17b0c90 into dev Apr 26, 2023
@lechnerc77 lechnerc77 deleted the ublock-patch-1 branch April 26, 2023 09:42
@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.8.0 Apr 28, 2023
@lechnerc77 lechnerc77 added the available in dev fix/enhancement is available in dev label Apr 28, 2023
@lechnerc77 lechnerc77 mentioned this pull request Apr 28, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lechnerc77 lechnerc77 lechnerc77 left review comments

@rui1610 rui1610 Awaiting requested review from rui1610

Assignees
No one assigned
Labels
available in dev fix/enhancement is available in dev bug Something isn't working
Projects
No open projects
btpsa planning
Status: Done
Milestone
btpsa-v1.8.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ublock @lechnerc77