Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

implement proper handling of appName for apps #453

Merged
merged 5 commits into from
Mar 9, 2023

Conversation

rui1610
Copy link
Contributor

@rui1610 rui1610 commented Mar 8, 2023

Purpose

This PR implements a proper handling of app subscriptions that have an appName that differs from the commercialAppName.

Does the PR solve an issue

[ ] Yes - Please add issue number
[x] No

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Add the app subscription for "integrationsuite". Without this PR the btp-setup-automator won't find the respective app subscription in your sub account, as the appName differs from the commercialAppName.

What to Check

Verify that the following are valid

  • The app subsucription works for integrationsuite

Other Information

Once "slim" integration test is done, I'll request a review for the updated code.

@rui1610 rui1610 added the bug Something isn't working label Mar 8, 2023
@rui1610 rui1610 added this to the to be planned milestone Mar 8, 2023
@rui1610 rui1610 requested a review from lechnerc77 March 8, 2023 19:29
@rui1610
Copy link
Contributor Author

rui1610 commented Mar 8, 2023

"Slim" integration test ran through without any issues (https://github.com/SAP-samples/btp-setup-automator/actions/runs/4367592247).

I've just started as well the "full" integration test (https://github.com/SAP-samples/btp-setup-automator/actions/runs/4367881386), to see whether there are other cross-dependencies I've overlooked with this PR.

@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.6.0 Mar 8, 2023
Copy link
Member

@lechnerc77 lechnerc77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be discussed, not approved

libs/python/helperCommandExecution.py Outdated Show resolved Hide resolved
@lechnerc77 lechnerc77 merged commit 1796a45 into dev Mar 9, 2023
@lechnerc77 lechnerc77 deleted the improve-handling-appname branch March 9, 2023 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants