Skip to content
This repository has been archived by the owner on Feb 13, 2024. It is now read-only.

Subdomain creation #451

Merged
merged 1 commit into from
Mar 7, 2023
Merged

Subdomain creation #451

merged 1 commit into from
Mar 7, 2023

Conversation

AlexRieder
Copy link
Contributor

Purpose

  • Used shortuuid instead of global account id for the creation of the subdomain

Does the PR solve an issue

[x ] Yes - #260 
[ ] No

Does this introduce a breaking change?

[ ] Yes
[x ] No - at least I think so

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Execute any scenario

What to Check

Verify that the following are valid

  • The subdomain should be created from the subaccount name plus a 10 digit uuid

Other Information

@lechnerc77 lechnerc77 self-assigned this Mar 7, 2023
@lechnerc77 lechnerc77 added the enhancement New feature or request label Mar 7, 2023
@lechnerc77 lechnerc77 added this to the to be planned milestone Mar 7, 2023
@lechnerc77 lechnerc77 self-requested a review March 7, 2023 13:02
@lechnerc77 lechnerc77 merged commit e0a6d21 into SAP-samples:dev Mar 7, 2023
@lechnerc77
Copy link
Member

Fixes #260

@lechnerc77
Copy link
Member

Validated; https://github.com/SAP-samples/btp-setup-automator/actions/runs/4354419962/jobs/7609728182
Issues arise due to delayed propagation of entitlements, not related to this change

@lechnerc77 lechnerc77 modified the milestones: to be planned, btpsa-v1.6.0 Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants