Skip to content
This repository has been archived by the owner on Jun 3, 2024. It is now read-only.

adds npm install for husky #14

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

adds npm install for husky #14

wants to merge 3 commits into from

Conversation

seVladimirs
Copy link

@seVladimirs seVladimirs commented Nov 23, 2021 •
edited
Loading

  • adds instructions how to install husky with npm (and not with yarn only)
  • fixes typos in path to husky folder

@qmacro
Copy link
Contributor

qmacro commented Nov 23, 2021

Thanks for the PR, @seVladimirs ! Can you please add some description so we know what your intentions are with this? Thanks!

seVladimirs
seVladimirs commented Nov 23, 2021
View reviewed changes
section/git-commit-hooks/README.md
Comment on lines +15 to +20
### NPM
```
npx husky-init && npm install
```


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've simple tried to execute instruction step by step without having yarn installed and failed. this fix will include also instructions for NPM

section/git-commit-hooks/README.md
### Yarn
```
yarn husky set ./husky/pre-commit "npx pretty-quick --staged"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you execute this line it will fail as path to husky folder is wrong, it should be .husky instead.

@seVladimirs
Copy link
Author

@qmacro done, also commented directly in the code review

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@seVladimirs @qmacro