WEEK2CHALLENGE flavio.ciotola3

topics/Week2_Best_Practices/challenge/btpguid.myscript → topics/Week2_Best_Practices/challenge/btpguid

@@ -1,3 +1,4 @@
+#!/usr/bin/env bash
 # btpguid - return BTP subaccount/directory GUIDs
 
 # Usage: btpguid [-t|--target] displayname
@@ -25,25 +26,24 @@ btp get accounts/global-account --show-hierarchy 2>/dev/null
 main() {
 
 local hierarchy subtype guid displayname rc=0
-local event=Devtoberfest
 
   displayname="${2:-$1}"
 
-  [[ -z displayname ]] && {
+  [[ -z $displayname ]] && {
     echo "No display name specified"
     exit 1
   }
 
   hierarchy="$(gethier)" || { btp login && hierarchy="$(gethier)"; }
-  read subtype guid <<< "$(grep -P -o "^(subaccount|directory)\s+(\S+)(?=\s+$displayname)" <<< $hierarchy)"
+  read -r subtype guid <<< "$(grep -P -o "^(subaccount|directory)\s+(\S+)(?=\s+$displayname)" <<< "$hierarchy")"
 
   # Set the subtype as target if requested
   [[ $1 == -t ]] || [[ $1 == --target ]] && {
     btp target "--${subtype}" "$guid" &> /dev/null
     rc=$?
   }
 
-  echo $guid
+  echo "$guid"
   return $rc
 
 }