-
-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add explicit support for JRuby #234
Add explicit support for JRuby #234
Conversation
I'm glad with the fact of supporting JRuby, thanks for contribute it. |
More information: jruby/jruby#1469 (comment)
Nokogiri for MRI handles [] and nil the same when calling #canonicalize However, Nokogir for JRuby blows up with []. The default argument according to the method definition is nil, so I believe it's more appropriate: http://www.rubydoc.info/github/sparklemotion/nokogiri/Nokogiri/XML/Node#canonicalize-instance_method
45b33bd
to
50931cf
Compare
I have updated this PR, because of conflicts with the recent changes in master. What are the chances of this being merged? Also, besides the Nokogiri mentioned above. JRuby 1.7.20 also has some change in behavior (in Thanks, |
JRuby 9000 is out, and jruby-openssl 0.9.8 fixes some X509 cert parsing issues. I updated the pull request. I am aware that there are merge conflicts: I will gladly resolve them again if there is interest from the committers in merging this PR. |
Apologies for not merging your PR on time, I think that supporting JRuby makes sense since it not requires much changes and can help some of the java-customers. Please fix conflicts, we will review the changes, test and include it on the master branch. |
…port_0.9_rebase * upstream/master: (47 commits) Handle empty URI references as per http://www.w3.org/TR/xmldsig-core/#sec-Same-Document; thx to @sixto for resolving a test case failure. support nameid in attribute values first attempt at adding support for scoped attributes needs additional work and tests Add some documentation about the soft setting parameter Update readme.md for 1.0.0 release Update date of the 1.0.0 release Update Readme and changelog Security improvement: Avoid entity expansion (XEE attacks) According to the xsd, the issuer has to be before the status Update changelog Fix SAML-Toolkits#244, related to PR SAML-Toolkits#243. Fix bug on metadata. Reorder KeyDescriptors Add logging information to README Allow logging to be delegated to an arbitrary Logger. Add tests for existing Logging functionality no more silent failure fetching idp metadata fix schema validation errors in service provider metadata tests to validate service provider metadata xml against the schema ignore gemfile.lock files in the gemfiles directory Prepare 1.0.0 release Improve compatibility with namespaces ...
@pitbulk I've fixed the merge conflicts and added support for JRuby-1.7.21 and JRuby-9.0.0.0. Thank you, |
We will review it and get it merged this week. Thanks for contributing!. |
Add explicit support for JRuby
@ylansegal does the issue you have with schema validate relate to not being able to validate on hard validation? I do get an invalid_ticket error in JRuby but not on MRI. response = RubySaml::Response.new(request.params['SAMLResponse'], options)
unless response.is_valid?
raise ValidationError.new(response.errors.join('\n'))
end |
@keaplogik Are you seeing issues after this PR was merged? All the ones I was having where solved. The issue with the schema validation that I mentioned in the original post was solved by not memoizing the I am not sure what is causing your |
OK thanks. Looks to be a separate issue I may need to do some more verification on my test. Looks like a digest mismatch error. |
Changes Unknown when pulling 7d86fe2 on ylansegal:feature/jruby_support_0.9 into ** on onelogin:master**. |
Dear maintainers, I would like to explicitly add support for JRuby to this gem. I was able to make the necessary changes, as follows:
been resolved in 1.6 series, so I use that version when in JRuby
Nokogiri::XML::Node#canonicalize
method in Nokogiri also behaves differently in JRuby vs MRI. However, that is easily solved by passing innil
(which is the default parameter) instead of[]
for the inclusive_namespaces.I believe 3 is the only real change in behavior for the gem. I'd appreciate your feedback.
Travis build: https://travis-ci.org/ylansegal/ruby-saml/builds/61692511
Thanks