Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CohortNode - add warning when selecting individual samples config that gives unintuitive results #1159

Open
davmlaw opened this issue Sep 5, 2024 · 2 comments
Open

CohortNode - add warning when selecting individual samples config that gives unintuitive results #1159

davmlaw opened this issue Sep 5, 2024 · 2 comments
Assignees
@davmlaw
Labels
Analysis bug Something isn't working
Milestone
SA Path VG 4

Comments

@davmlaw
Copy link
Contributor

davmlaw commented Sep 5, 2024 •
edited
Loading

In an analysis I selected individual samples, removed a few and the numbers came back extremely large, much larger than all samples
@davmlaw davmlaw added Analysis bug Something isn't working labels Sep 5, 2024
@davmlaw davmlaw self-assigned this Sep 5, 2024
@davmlaw davmlaw added this to the SA Path VG 4 milestone Sep 5, 2024
davmlaw added a commit that referenced this issue Dec 10, 2024
@davmlaw
#1159 - CohortNode - wrong counts after selecting individual samples
ed7bb94
@davmlaw
Copy link
Contributor Author

davmlaw commented Dec 10, 2024

Fixed.

Also, it is confusing if you leave it all ticked by default as "no zygosity call in sample" for 1 sample shows all. Maybe add a warning message about this?

davmlaw added a commit that referenced this issue Dec 11, 2024
@davmlaw
issue #1159 - cohort per sample zygosity warnings, and return empty i…
91c2f1c 
…f none selected
@davmlaw
Copy link
Contributor Author

davmlaw commented Dec 11, 2024

Added new warnings for per sample zygosity filters:

  • No zygosity in any samples
  • No visible samples
  • all zyg calls for any sample with any ticked (will show everything)

@davmlaw davmlaw changed the title CohortNode - wrong counts after selecting individual samples CohortNode - add warning when selecting individual samples config that gives unintuitive results Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davmlaw davmlaw

Labels
Analysis bug Something isn't working
Projects
None yet
Milestone
SA Path VG 4
Development

No branches or pull requests
1 participant
@davmlaw