fix missing header and incorrect asm

[dzhang20]

Module:
fix missing header and incorrect asm instruction
Description:
Latest update on master branch introduce few of the issues that will prevent users from successfully building the code when running "s2e update && s2e build". The issues are detailed below:

1. the errno is used without correctly including the errno.h header in libtcg/src/utils/memalign.c.
2. In guest/s2ebios/tests/tests64.asm, the use of lea instruction is in an incorrect way that will cause compilation issue. lea (Load Effective Address) instruction in assembly language allows you to perform arithmetic operations while moving data. It's typically used to calculate the addresses of variables. However, in the test file, it's used as lea rcx, 0x20000 in few of the places. Thus, I tentatively replaced lea with mov (waiting for authors approval).

Signed-off-by: Ding Zhang [email protected]

[vitaly-cyberhaven]

This looks much easier to review, thanks for re-submitting. Any reason you couldn't reopen the old PR and force-push there? That would help keep track of comments in one place.

A couple more things:

• Split the commit into two: the header fix and the asm fix. They are unrelated and should be separate.
• Prefix the commit message appropriately (see git history for examples).

[dzhang20]

This looks much easier to review, thanks for re-submitting. Any reason you couldn't reopen the old PR and force-push there? That would help keep track of comments in one place.

A couple more things:

• Split the commit into two: the header fix and the asm fix. They are unrelated and should be separate.
• Prefix the commit message appropriately (see git history for examples).

Sorry, the previous branch with the old pr is deleted and one new branch with the same name is then being created by another user. Thus, I think it's easier to reissue another pr in a clean state.
I have update the pr with the changes:

1. split commit into two
2. prefix the commit message

Best

[vitalych]

Please rebase on master instead of merging master into the branch. I see a "Merge branch master" commit. These should not be in the PR.

[dzhang20]

Please rebase on master instead of merging master into the branch. I see a "Merge branch master" commit. These should not be in the PR.

Done

[vitalych]

nasm on my system doesn't throw any error on this. I am curious what's on yours.

[dzhang20]

It throws error: invalid combination of opcode and operands

[vitalych]

You also need to run clang format (see failing test)