Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#338 File name chosen by user when creating map #339

Merged
merged 1 commit into from
May 20, 2022

Conversation

MatthewFoster02
Copy link
Collaborator

The user is prompted to give a name to the file before it is created. Improving upon the messy way of trying to remember to do so on the settings panel before creating the map.

Closes #338

The user is prompted to give a name to the file before it is created.
@MatthewFoster02 MatthewFoster02 added the refactor Rewrite exisiting code label May 19, 2022
@MatthewFoster02 MatthewFoster02 self-assigned this May 19, 2022
Copy link
Collaborator

@Jolijn2020 Jolijn2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!
works well

@S010MON
Copy link
Owner

S010MON commented May 20, 2022

If you close the alert without submitting the name, the user is still informed that the file has been created

@trav-d13 trav-d13 merged commit 884bf00 into master May 20, 2022
@MatthewFoster02 MatthewFoster02 deleted the 338-ask-for-file-name-before-creating-map branch May 20, 2022 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Rewrite exisiting code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ask for file name before creating map.
4 participants