Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makes target visible #328

Merged
merged 4 commits into from
May 17, 2022
Merged

Makes target visible #328

merged 4 commits into from
May 17, 2022

Conversation

S010MON
Copy link
Owner

@S010MON S010MON commented May 16, 2022

Adds a flag to the center of the target to make it visible to agents

closes #327

@S010MON S010MON self-assigned this May 16, 2022
@S010MON S010MON linked an issue May 16, 2022 that may be closed by this pull request
@S010MON S010MON requested a review from Jolijn2020 May 16, 2022 16:23
Copy link
Collaborator

@Jolijn2020 Jolijn2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this approach would mean that we have to create a new class for every type of flag we want to use, instead of just using a different enum Type.

I understand that instead of being able to see the whole area, you just want to use a small marker in the middle of it, but this might become a problem, or at least an inconvenience in two scenario's:

  1. if the agent has a part of the Target in view, but not the middle, they can't see it.
  2. If agents start using flags to communicate, they might block of walls or just open space. And since there is currently no distinction between an object being visible and being solid, agent would not be able to walk over it. And if you add that distinction, it can block the agents vision.

I'm not certain if those things are worth it, just to not have to store boolean variables.
The other approach also makes it possible to make things like glass and portals visible (debate whether it's necessary for glass, but portal would be very usefull)

@MatthewFoster02
Copy link
Collaborator

When I run the code, agents can move through glass.

@S010MON
Copy link
Owner Author

S010MON commented May 17, 2022

Closed in favour of #328

@S010MON S010MON closed this May 17, 2022
@Jolijn2020 Jolijn2020 reopened this May 17, 2022
Copy link
Collaborator

@Jolijn2020 Jolijn2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Target uses 2 different classes implementing Boundary, why are they different classes?

@S010MON S010MON merged commit abfdda2 into master May 17, 2022
@S010MON S010MON deleted the 263-make-target-visible branch May 17, 2022 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

make target visible
3 participants