Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adds sound when agents move at a decay rate of 0.5 #296

Merged
merged 3 commits into from
May 8, 2022

Conversation

S010MON
Copy link
Owner

@S010MON S010MON commented May 7, 2022

Closes #272 move noises

@S010MON S010MON self-assigned this May 7, 2022
@trav-d13
Copy link
Collaborator

trav-d13 commented May 8, 2022

When running app on Map1.txt, it visually looks and runs really well with the decay rate. However in terminal I get the below error message. To reproduce the error run Map1.txt

Error

Copy link
Collaborator

@MatthewFoster02 MatthewFoster02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I too get the Null pointer exception mentioned by @trav-d13 Also on the first run there was another Null pointer exception on line 40 of Sound Engine caused by 'endPoint' being Null. Cannot recreate this since however but the initial one is consistent.

MatthewFoster02
MatthewFoster02 previously approved these changes May 8, 2022
trav-d13
trav-d13 previously approved these changes May 8, 2022
Copy link
Collaborator

@trav-d13 trav-d13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run well!

@S010MON S010MON dismissed stale reviews from trav-d13 and MatthewFoster02 via 4a5e371 May 8, 2022 17:01
@S010MON S010MON merged commit 68e56b4 into master May 8, 2022
@S010MON S010MON deleted the 272-soundengine-move-noises branch May 8, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SoundEngine: Move Noises
3 participants