patches bug #293 #294
Merged
patches bug #293 #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MatthewFoster02
approved these changes
Apr 28, 2022
S010MON
deleted the
293-cannot-invoke-appcontrollerlinalgvectorgetx-because-b-is-null-bug
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #293: bug was caused by the sound engine trying to stochastically bounce sound rays from just short of the line that represents the boundary/agent (this is required to stop sound rays becoming trapped within the interior of walls accidentally). The minuscule distance between the agent and the sound ray caused issues as the vector created held NaN values that then spawned their own NaN children in a markov chain.
Patched with a distance check that should have minimal impact on performance and is unlikely to be actioned in all but the rarest cases.