Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WF agent shared memory graph implementation #269

Merged
merged 6 commits into from
Apr 25, 2022
Merged

Conversation

laurajogi
Copy link
Collaborator

@laurajogi laurajogi commented Apr 21, 2022

Currently has a bug: the agent sometimes does weird movements again - especially after having moved forward once after turning around a corner. This happens because the agent does not seem to detect the wall on the left for some reason.

…oes weird movements again - especially after having moved forward once after turning around a corner, as the agent does not seem to detect the wall on the left.
@laurajogi laurajogi linked an issue Apr 21, 2022 that may be closed by this pull request
@laurajogi laurajogi changed the title Made WF agent use shared memory graph. However, the agent sometimes d… Made WF agent use shared memory graph Apr 21, 2022
@laurajogi laurajogi changed the title Made WF agent use shared memory graph WF agent shared memory graph implementation Apr 21, 2022
# Conflicts:
#	src/main/java/app/model/agents/MemoryGraph.java
…adjust_vertex method and connectNeighbouringVertices method. WFAgent still has a bug in one specific movement.
…e fix makes sure that the MemoryGraph is WfWorld instance for the WF agent tests.
@laurajogi
Copy link
Collaborator Author

WF agent has full implementation of the shared MemoryGraph but still has a bug in a specific movement that I will fix later in another branch.

@laurajogi laurajogi marked this pull request as ready for review April 24, 2022 18:34
@laurajogi laurajogi requested review from S010MON and trav-d13 April 24, 2022 18:35
@trav-d13
Copy link
Collaborator

Hey Laura, the code looks really great!
I just tried to create two new maps, and both of them throw errors when executing, is this bug due to the specific movement?
This is the error message I get back.
One-true-graph error

@trav-d13 trav-d13 merged commit 1998404 into master Apr 25, 2022
@S010MON S010MON deleted the WF-one-true-graph branch April 28, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WF shared graph implementation
3 participants