Aco agent multi map movement #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er for binary search to work. "
…oint binary search"
# Conflicts: # src/main/java/app/controller/GameEngine.java # src/main/java/app/model/Map.java # src/main/java/app/model/boundary/InvisibleBoundary.java # src/main/java/app/view/Frame.java
…ing less than 360 rays"
…ng in non-legal move"
Jolijn2020
reviewed
Mar 9, 2022
Jolijn2020
reviewed
Mar 9, 2022
S010MON
requested changes
Mar 9, 2022
There was a problem hiding this comment.
I'm getting a consistent error:
Cardinal Point not found
Cardinal Point not found
Exception in thread "JavaFX Application Thread" java.lang.NullPointerException: Cannot invoke "app.controller.graphicsEngine.Ray.rayLength()" because "cardinalRays[i]" is null
at app@1.0-SNAPSHOT/app.model.agents.ACO.AcoAgent.determineAvailableMovements(AcoAgent.java:172)
at app@1.0-SNAPSHOT/app.model.agents.ACO.AcoAgent.determineMovesAllScenarios(AcoAgent.java:88)
at app@1.0-SNAPSHOT/app.model.agents.ACO.AcoAgent.move(AcoAgent.java:55)
at app@1.0-SNAPSHOT/app.controller.GameEngine.tick(GameEngine.java:42)It seems that the addition of throwing an exception has exposed a problem that was handled with print statements.
Consider a runtime error instead?
throw new RuntimeException("Cardinal Point not found");
Up to you to advise if this is a serious error or trivial and should be returned to a System.out.println for Info logging
…gentMultiMapMovement # Conflicts: # src/main/java/app/model/Map.java
Added boundaries
This was
linked to
issues
Mar 10, 2022
Closed
S010MON
previously approved these changes
Mar 10, 2022
MatthewFoster02
previously approved these changes
Mar 10, 2022
|
Dude ... two people reviewed this request and you just left it, now it's out of date with conflicts. Not cool |
# Conflicts: # src/main/java/app/controller/graphicsEngine/RayTracing.java # src/main/java/app/model/Map.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working and checked. Two bug fixes completed