Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map builder refactor #175

Merged
merged 4 commits into from
Mar 8, 2022
Merged

Map builder refactor #175

merged 4 commits into from
Mar 8, 2022

Conversation

S010MON
Copy link
Owner

@S010MON S010MON commented Mar 7, 2022

Brief refactor of the MapBuilder to remove reliance on modification of Settings using blind reference in void method and cleans up unused imports and public methods that could be made private

@S010MON S010MON added the refactor Rewrite exisiting code label Mar 7, 2022
@S010MON S010MON requested a review from MatthewFoster02 March 7, 2022 21:18
@S010MON S010MON self-assigned this Mar 7, 2022
Copy link
Collaborator

@MatthewFoster02 MatthewFoster02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor looks good.

@S010MON S010MON merged commit c3f07a4 into master Mar 8, 2022
@S010MON S010MON deleted the mapBuilder-refactor branch March 8, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Rewrite exisiting code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants