Homepage #5
Open
Homepage #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fix lint issues |
GLObus303
requested changes
Dec 2, 2021
|
|
||
| const baseUrl = 'http://localhost:3000'; | ||
|
|
||
| export const axiosGet = async <T = any>( |
There was a problem hiding this comment.
Consider removing the any here and below, to force others to always provide the generic param
| const TextContainer = styled.div` | ||
| background: rgba(255, 255, 255, 0.6); | ||
| box-shadow: 0 -2px 12px rgba(#000, 0.3); | ||
| padding: 10px 12px; |
There was a problem hiding this comment.
Stick to rem units everywhere, apart from stuff that needs to be "fixed" like borders f.e. Use you best judgment
| }) | ||
| } | ||
|
|
||
| function uuidv4() { |
There was a problem hiding this comment.
if you will export this one out, you can use it for uuid if you need it somewhere.
|
Squash all of the commits into one (I can show you how to do it). You better learn how to do it manually. It will become handy |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pls review