Skip to content
This repository has been archived by the owner on Jan 23, 2024. It is now read-only.

Fix input tester in the gui for all steam deck controls #93

Open
wants to merge 9 commits into
base: python3
Choose a base branch
from

Conversation

Dark3clipse
Copy link

@Dark3clipse Dark3clipse commented Jul 12, 2023

I noticed that the input tester functionality was only half working on the steam deck. The right stick didn't show as well as some grips, dot button, and the dpad.

This PR attempts to fix this.

steam-deck-input-test-fix.webm

@Dark3clipse
Copy link
Author

It seems dpad was not supported for other controllers as well. I will do some further testing with other controllers, I think I need to make the code more compatible before it can be merged.

…or deck.svg and ds5.svg; fix bug in enable_test_mode when controller switching
@Dark3clipse
Copy link
Author

Dark3clipse commented Jul 21, 2023

I make the dpad test area configurable in the controller svg files and added it to ds5 and deck svgs. I only have those two controllers. Also, there was a bug in enable_test_mode when switching active controller. I made a fix for this.

A further improvement: it seems the input tester does not apply deadzones, resulting in the tester being visible in the center of the stick even when you have set a deadzone. I probably need some help to know how to solve this.

@Ryochan7
Copy link
Owner

This cannot be merged as is. This commit breaks the GUI for Steam Controller mapping. It breaks mainly when it comes to the back grip buttons. Hopefully I will be able to take a look and see if something small can be changed to fix those buttons.

@Ryochan7
Copy link
Owner

Looks like the GUI is actually wrong (at least the icons) in your video as well.

@Dark3clipse
Copy link
Author

Dark3clipse commented Jul 27, 2023

I don't have a steam controller to test with. What part exactly of the gui is wrong?

Im on vacation right now. Ill continue working on this when i am back home

@Ryochan7
Copy link
Owner

Ryochan7 commented Nov 8, 2023

Long time. Anyway, here is a small demo showing what I was talking about. LGRIP, RGRIP, Left Touchpad, and Right Touchpad use the wrong icon graphics although they are still linked to the correct inputs when opening the action editor. The original python3 interface is also shown for comparison.

The errors in the changed interface are as follows. LGRIP input uses the RGRIP icon graphic. RGRIP input uses the Left Touchpad icon graphic. Left Touchpad input uses the Stick icon graphic. Right Touchpad input uses the Left Touchpad icon graphic.

sc_controller_gui_buttons.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants