Making it easier to download larger collections #18
Conversation
| // Whether the download tab should automatically be closed after the download has been started | ||
| var closeAfterDownload = true | ||
| var closeAfterDownload = false //some weirdo shit happens when this is true. Will need to investigate more |
There was a problem hiding this comment.
Not sure, I was missing downloads when close after download was true but when I left it off it seemed to work fine. I'm not confident on what the issue was so I just noted for myself the behavior seemed off so if I wanted to investigate it I could
| var albumLoadDuration = 10000; | ||
| var albumLoadDuration = 30000; //30000 ms default - 30 sec default | ||
| //If true will make the time it takes to open new links entirely random. If false will use a set interval | ||
| const randomInterval = false; |
There was a problem hiding this comment.
What's the purpose of having this option?
There was a problem hiding this comment.
Was my initial approach. I left it in because I figured since I already programmed it having the option would be nice
|
Can we remove the semicolons so that things are consistent? I don't really care if they're there or not, but I'd like to be consistent |
|
Yeah, no complaints. I just program mostly in C and Verilog these days so it's force of habit. I also wouldn't be bothered if const and let were replaced by var. More force of habit stuff since I use predominantly ES6. I present the code as is for you to do whatever you want with. I mostly put it together for myself but I saw someone opened an issue asking for a fix I already made I figured I should share it. |
|
Sounds good to me. I'll make those few tweaks and add it in when I have a chance |
|
would love to see this merged. Just tried to download my collection and get the 429 error. Thanks for this software btw! |
|
I can't get this to work correctly. I update the script for the download format and select 6 albums. The page for the first album opens and the format is applied to the download, but nothing downloads and it does not continue to the next album. Did Bandcamp change something about their site that needs a different command to start the download? I would try to diagnose it, but I don't know java very well. Thanks. |
I formatted it the way I like since I didn't anticipate making a PR