🐛 Fixes #46 Carthage build

[esttorhe]

Due to a misconfiguration in the project settings when building using Carthage was failing because the project was unable to find RxSwift dependencies

[esttorheBot]

Generated by 🚫 danger

[freak4pc]

What was the reason for changing the import here? Supporting multiple targets? Do we even need any of these imports for this to work? Rest looks great !

[esttorhe]

Including UIKit seemed illogical given that the framework supports all 4 platforms and after the changes I made the macOS target wasn't compiling

[freak4pc]

Yeah makes total sense, I just wondered if we even need the Foundation import there to begin with or it would probably work without?

[freak4pc]

Very interesting yet probably not related to this PR, from the tvOS failed CI on Travis

fatal error: Warning: Recursive call or synchronization error!: file /Users/travis/build/RxSwiftCommunity/RxViewModel/Demo/Pods/RxSwift/RxSwift/Observables/Implementations/AnonymousObservable.swift, line 27

Worth looking into at some point @esttorhe

[codecov-io]

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   86.82%   86.82%           
=======================================
  Files           5        5           
  Lines         258      258           
=======================================
  Hits          224      224           
  Misses         34       34

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9fc9da6...92c3541. Read the comment docs.

[freak4pc]

I don't know the CLANG_WARNIG_INFINITE_RECURSION flag but the fact it was disabled doesn't just silences the warning instead of taking care of the root cause? Or that would be a separate ticket?

[esttorhe]

@freak4pc I left the flag as it was originally for now.

As stated on the commit message I need to dig deeper and see how/if RxSwift has this flag on because the error is happening deep into RxSwift and not on RxViewModel level which means that first we would have to patch/fix it there; then turn the flag back on here and update with the latest version.

[freak4pc]

@esttorhe AFAIK that recursion error is a warning within RxSwift about code using RxSwift, e.g. it does seem like it is something within RxViewModel but its interesting it only occurred when building on tvOS. If I have a few minutes later this week I'll try building it with the flag and see if I can find anything funky :)

[esttorhe]

@freak4pc you might be right :)

I'm going to check this week and see if I can find the root cause of the issue (given that Travis is refusing to load that log for me)

Thanks 😄

[esttorhe]

Looks like its passing (for now) going to merge and will keep monitoring this issue.

Sadly TravisCI refuses to serve me the failed log and thus makes it quite hard for me at the moment to try and fix.

Will keep try locally but i'm going to merge this now

[freak4pc]

Sounds good. I'll also try keeping an eye for this issue.
And yeah, Travis is horrid. I still keep hoping everyone will move their OSS projects to Buddybuild 👼