Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HasDisposeBag.swift to SwiftPM #82

Merged
merged 1 commit into from
Apr 23, 2020
Merged

Add HasDisposeBag.swift to SwiftPM #82

merged 1 commit into from
Apr 23, 2020

Conversation

mtfum
Copy link
Member

@mtfum mtfum commented Apr 18, 2020

#trivial
We can't use HasDisposeBag when using SwiftPM.
So I added file source!
please review, thanks!

@mtfum mtfum requested a review from pomozoff April 18, 2020 08:51
@rxswiftcommunity
Copy link

rxswiftcommunity bot commented Apr 18, 2020

It looks like code was changed without adding anything to the Changelog.

Generated by 🚫 dangerJS

@mtfum mtfum requested a review from ashfurrow April 18, 2020 08:51
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Sorry for the delay, let me get this released for you 👍

@ashfurrow ashfurrow merged commit 36839a6 into RxSwiftCommunity:master Apr 23, 2020
@ashfurrow
Copy link
Member

Okay! That's released as 5.1.1 🌟

Thanks again!

@mtfum mtfum deleted the add-HasDisposeBag branch April 25, 2020 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants