-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SPM support #79
Add SPM support #79
Conversation
It looks like code was changed without adding anything to the Changelog. Thanks a lot for contributing @pomozoff! I've invited you to join the Generated by 🚫 dangerJS |
Thanks for opening the PR! It looks like CocoaPods is adding NSObject-Rx/NSObject+Rx.podspec Line 20 in 11e5a2b
I think we can change this line to |
@ashfurrow, thanks for helping! Should I replace |
Nearly! The s.source_files = ["NSObject+Rx.swift", "HasDisposeBag.swift"]
s.source_files = %w(NSObject+Rx.swift HasDisposeBag.swift) One is just easier to copy/paste filenames into, so you see |
Thank you a lot! Everything is clear now ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge when CI is green. Then we can tag a release 👍
Okay, tagged a release of 5.0.3 on git. Let me know if I can help further, and thanks again! |
#trivial