Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build in Circle CI 2.0 #68

Merged
merged 21 commits into from
May 4, 2019
Merged

Build in Circle CI 2.0 #68

merged 21 commits into from
May 4, 2019

Conversation

fassko
Copy link
Member

@fassko fassko commented May 3, 2019

  • increase watchOS minimum version because of RxSwift
  • remove Pods from Demo project to build in CI

@fassko fassko requested a review from freak4pc May 3, 2019 16:26
@freak4pc
Copy link
Member

freak4pc commented May 3, 2019

Hey @fassko, thanks !
Not sure why but a rebase isn't possible (conflicting) - could you rebase on top of master?

Also, I'm wondering why are there so many changes if all was needed is a new config? Is it the Pods removal I imagine?

.circleci/config.yml Outdated Show resolved Hide resolved
@fassko
Copy link
Member Author

fassko commented May 4, 2019

@freak4pc I had to remove Pods because there is some problem with other machines like Circle CI. Also it will make repo smaller.

I will try to rebase.

@fassko fassko requested a review from freak4pc May 4, 2019 09:00
@fassko
Copy link
Member Author

fassko commented May 4, 2019

I did rebase from master.

@fassko fassko self-assigned this May 4, 2019
@freak4pc
Copy link
Member

freak4pc commented May 4, 2019

Uhm doesn't seem like it ... can you take a look again? Worst case I can just merge it but I prefer a rebase:
image

@freak4pc freak4pc merged commit b0923b8 into RxSwiftCommunity:master May 4, 2019
@freak4pc
Copy link
Member

freak4pc commented May 4, 2019

Not sure why but this is failing on master. Any thoughts? https://circleci.com/gh/RxSwiftCommunity/NSObject-Rx/62

@fassko
Copy link
Member Author

fassko commented May 4, 2019

Hmm something is weird with keys. Do you have access to settings of this repo? To see if key which is in Circle is valid?

@freak4pc
Copy link
Member

freak4pc commented May 4, 2019

OK, passing now. Thanks @fassko !

I'm a bit confused by two things:

  1. Why do we need both CocoaPods and Carthage for CI? More specifically it seems like Carthage isn't being used at all. Is it there just to confirm it's building?

  2. Seems we're only testing iOS... Would be good to do the other supported platforms as well.

@fassko
Copy link
Member Author

fassko commented May 4, 2019

  1. I think you're right Carthage is needed only for local development if you want to edit Xcode project. I will remove it to speed up the build.

  2. True, this is very good recommendation.

I will create issues for both of these things otherwise I forget things quickly. :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants