hotfix: RxSwift 4.0 and Carthage ketchup #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The HasDisposeBag PR RxSwiftCommunity#49 should add it back.
…sn't cut it, as is also the case with cocoapod instructions.
Gurpartap
force-pushed
the
hotfix/carthage-rxswift-4
branch
from
c896539 to
79bb89e
Compare
$ cd ~/path/to/SomeProject/
$ cat Cartfile$ carthage update --platform iOS --no-use-binaries
*** Fetching NSObject-Rx
*** Fetching RxSwift
*** Checking out RxSwift at "4.0.0"
*** Checking out NSObject-Rx at "79bb89e870ad7d10242069965c9d8f08e97c9378"
*** ...
*** Building scheme "RxSwift-iOS" in Rx.xcworkspace
*** Building scheme "NSObject_Rx" in NSObject-Rx.xcodeproj
|
ashfurrow
approved these changes
Oct 26, 2017
|
The above output demonstrates the resolved RxSwift version after the PR patch, which is 4.0 instead of the incompatible 3.6.x before. LGTM. Merge and release? |
|
Thanks a lot for contributing! I've invited you to join the RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like more information on what that means, check out our contributor guidelines and feel free to reach out with any questions. |
This was referenced Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catch up*
I've removed the missing HasDisposeBag.swift reference from the Xcode project so that the project compiles. Perhaps /pull/49 can suitably add it back.