Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Demo build fail supporting Xcode 10 with Swift 4.2 #154

Merged
merged 6 commits into from
Sep 25, 2018
Merged

Fix Demo build fail supporting Xcode 10 with Swift 4.2 #154

merged 6 commits into from
Sep 25, 2018

Conversation

cruisediary
Copy link
Member

ashfurrow
ashfurrow approved these changes Sep 25, 2018
View reviewed changes
Copy link
Member

@ashfurrow ashfurrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, good working cleaning up the readme 👍

@ashfurrow ashfurrow merged commit a7ca634 into RxSwiftCommunity:master Sep 25, 2018
@rxswiftcommunity
Copy link

Thanks a lot for contributing @cruisediary! I've invited you to join the
RxSwiftCommunity GitHub organization – no pressure to accept! If you'd like
more information on what this means, check out our contributor guidelines
and feel free to reach out with any questions.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashfurrow ashfurrow ashfurrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cruisediary @ashfurrow