This repository has been archived by the owner on Aug 15, 2024. It is now read-only.
feat: allow version selection #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rustin170506
changed the title
epage
reviewed
Nov 30, 2023
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-spec
branch
from
b438761
to
46f8230
Compare
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
changed the title
Rustin170506
commented
Dec 1, 2023
epage
reviewed
Dec 1, 2023
src/ops/info.rs
Outdated
| @@ -29,12 +33,19 @@ pub fn info(spec: &str, config: &Config, reg_or_index: Option<RegistryOrIndex>) | |||
| if let Ok(root) = root_manifest(None, config) { | |||
| let ws = Workspace::new(&root, config)?; | |||
| if let Some(resolve) = ops::load_pkg_lockfile(&ws)? { | |||
| if let Ok(p) = resolve.query(spec) { | |||
| if let Ok(p) = resolve.query(spec.name()) { | |||
There was a problem hiding this comment.
You likely want to call specs_to_ids. It can return multiple results, just pick the highest.
- Avoids the need for the
matchescall below - Picks a value when there is ambiguity, rather than erroring and falling through to the registry (we should have a test case added for this)
There was a problem hiding this comment.
I am a little bit confused. It seems the specs_to_ids API also uses the query API internally.
It can only return one matched package or bail out an error:
/// Checks a list of `PackageId`s to find 1 that matches this `PackageIdSpec`. If 0, 2, or
/// more are found, then this returns an error.
pub fn query<I>(&self, i: I) -> CargoResult<PackageId>There was a problem hiding this comment.
Overlooked that. We likely want to just call .iter() and do our own calls to matches...
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-spec
branch
2 times, most recently
from
5e6864e
to
f661faf
Compare
Rustin170506
commented
Dec 2, 2023
| license: unknown | ||
| rust-version: unknown | ||
| documentation: https://docs.rs/my-package/0.2.3+my-package | ||
| note: to see how you depend on my-package, run `cargo tree --package [email protected]+my-package --invert` |
There was a problem hiding this comment.
Two versions were compared and the highest one was chosen.
Signed-off-by: hi-rustin <[email protected]>
Rustin170506
force-pushed
the
rustin-patch-spec
branch
from
f661faf
to
091ab5d
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #27