signature: remove RNG generic parameter from RandomizedSigner #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...replacing it with `impl CryptoRng + RngCore`. This is a SemVer breaking change, however per our policy around `*-preview` features, it will receive a minor version bump as these features are not part of the SemVer guarantees of this crate. The rationale for this change is the exact RNG method doesn't matter, especially to the point it needs to be a generic parameter of the trait signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...replacing it with
impl CryptoRng + RngCoreparameter.This is a SemVer breaking change, however per our policy around
*-previewfeatures, it will receive a minor version bump as these features are not part of the SemVer guarantees of this crate.The rationale for this change is the exact RNG method doesn't matter, especially to the point it needs to be a generic parameter of the trait signature.