Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update to rand_core v0.9.0 #1745

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

GeekMasher
Copy link

Updated the password-hash crate and fixed the issues with the changes in the rand_core API.

Let me know if you need / want any other changes done before merging.


By the way, awesome set of crates in this repository!

@GeekMasher
Copy link
Author

GeekMasher commented Feb 9, 2025

There are a few more things that apparently have been deprecated in rand_core such as Error which is no longer present in 0.9.0.

After updating crypto-common crate to 0.9.0 it seems that a few of the APIs return rand_core::Error like these:

How do you want to deal with these cases?

password-hash/src/salt.rs Outdated Show resolved Hide resolved
@tarcieri
Copy link
Member

tarcieri commented Feb 9, 2025

@GeekMasher since this PR for password-hash is basically done I'd suggest we leave crypto-common out for now and handle it in a separate PR

@newpavlov
Copy link
Member

I would prefer to migrate all trait crates in one PR. We not only need to bump rand_core version but also tweak APIs a bit as discussed in the issue. I recently started drafting it locally, but haven't finished it yet.

@GeekMasher
Copy link
Author

I've commited the changes @tarcieri suggested. I'm happy with either suggestions about changing crypto-common. I didn't think it would make breaking / API changes but it seems it will so wanted recommendations before writing any code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants