Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump signature to 2.0.0-pre #562

Merged
merged 1 commit into from
Oct 31, 2022
Merged

Bump signature to 2.0.0-pre #562

merged 1 commit into from
Oct 31, 2022

Conversation

tarcieri
Copy link
Member

Implements the proposed breaking changes to the signature crate from RustCrypto/traits#1141

Most notably the Signature trait has been replaced with a SignatureEncoding trait which permits an internally structured signature representation.

@tarcieri tarcieri force-pushed the signature/v2.0.0-pre branch from 5d6ae47 to e62c063 Compare October 30, 2022 03:06
@tarcieri
Copy link
Member Author

cc @aumetra @cobratbq @lumag

@tarcieri tarcieri force-pushed the signature/v2.0.0-pre branch from e62c063 to 0895d55 Compare October 30, 2022 03:10
@tarcieri
Copy link
Member Author

also cc @rozbb for the ed25519 crate changes

@lumag
Copy link
Contributor

lumag commented Oct 31, 2022

Ok. For me the s.to_der() still doesn't fit the generic code. What I'd probably like to see is the Signer / Verifier implementations for the p384::der::Signature struct.

@tarcieri
Copy link
Member Author

@lumag yup, I'm planning on adding those before another release, but would like to PR them separately

Implements the proposed breaking changes to the `signature` crate from
RustCrypto/traits#1141

Most notably the `Signature` trait has been replaced with a
`SignatureEncoding` trait which permits an internally structured
signature representation.
@tarcieri tarcieri force-pushed the signature/v2.0.0-pre branch from 0895d55 to 5088b7b Compare October 31, 2022 16:48
@lumag
Copy link
Contributor

lumag commented Oct 31, 2022

If only I could get rid of the F: Fn(&Signature) -> Vec<u8> closure in my code :-)

@tarcieri
Copy link
Member Author

@lumag you should be able to use SignatureEncoding::to_vec now

@lumag
Copy link
Contributor

lumag commented Oct 31, 2022

@tarcieri no, because of signature.to_der() for ECDSA. X.509 cerfificates use DER encoding.

@tarcieri
Copy link
Member Author

A forthcoming PR to let you sign directly with ecdsa::der::Signature should take care of that?

@lumag
Copy link
Contributor

lumag commented Oct 31, 2022

Hopefully

@tarcieri tarcieri merged commit 1eec6b4 into master Oct 31, 2022
@tarcieri tarcieri deleted the signature/v2.0.0-pre branch October 31, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants