pkcs1: fixups for DecodeRsaPublicKey blanket impl
#916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the error type to `spki::Error`, which matches the error type used in the `spki::DecodePublicKey` blanket impl: https://docs.rs/spki/0.7.0/spki/trait.DecodePublicKey.html#impl-DecodePublicKey-for-T Also removes the bounds on `DecodePublicKey` in the blanket impl of `DecodeRsaPublicKey`, since they aren't actually used. This is a breaking change but also a bugfix, as with the previous bounds it's not possible to impl PKCS#1 support via these two blanket impls, since the error types don't match. The plan is to merge this, publish it, and yank the v0.7.0 release.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the error type to
spki::Error, which matches the error type used in thespki::DecodePublicKeyblanket impl:https://docs.rs/spki/0.7.0/spki/trait.DecodePublicKey.html#impl-DecodePublicKey-for-T
Also removes the bounds on
DecodePublicKeyin the blanket impl ofDecodeRsaPublicKey, since they aren't actually used.This is a breaking change but also a bugfix, as with the previous bounds it's not possible to impl PKCS#1 support via these two blanket impls, since the error types don't match. The plan is to merge this, publish it, and yank the v0.7.0 release.