Fix repository field in Cargo.toml
#1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...but that's not displayed on crates.io. It would be nice to retain the direct links to the actual subdirectory containing the package somewhere that generates a clickable link on crates.io. Perhaps |
link2xt
force-pushed
the
link2xt/fix-cargo-toml-repository
branch
from
5560b84 to
6ceac8c
Compare
|
I moved old URLs to |
tarcieri
reviewed
Mar 31, 2024
link2xt
force-pushed
the
link2xt/fix-cargo-toml-repository
branch
2 times, most recently
from
4fea6e4 to
65ce901
Compare
According to https://doc.rust-lang.org/cargo/reference/manifest.html#the-repository-field `repository` is a source repository URL. GitHub URLs with `tree` are not repository URLs and are not usable as `git clone` arguments. Path within the worktree is encoded in `.cargo_vcs_info.json` of the crate, so encoding it in `Cargo.toml` is not necessary. I am automating downloading of crate sources and invalid URLs require workarounds to turn them into repository URLs that can be cloned.
link2xt
force-pushed
the
link2xt/fix-cargo-toml-repository
branch
from
65ce901 to
2cd4eeb
Compare
tarcieri
approved these changes
Mar 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://doc.rust-lang.org/cargo/reference/manifest.html#the-repository-field
repositoryis a source repository URL.GitHub URLs with
treeare not repository URLsand are not usable as
git clonearguments.Path within the worktree
is encoded in
.cargo_vcs_info.jsonof the crate,so encoding it in
Cargo.tomlis not necessary.I am automating downloading of crate sources
and invalid URLs require workarounds
to turn them into repository URLs that can be cloned.