Constructors for scalars from u128 #709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are helpful when using the scalars in Shamir secret sharing with random (128 bit) participants.
I didn't touch the field.rs files, as then automatic method selection in the
multiplicative_generator
implementations fails - so there is potentially a danger of backwards incompat in p256+p384 which don't haveFrom<u32>
.Personally, I'm only interested in
From<u128>
fork256
.