Fix clippy warnings #270
Merged
Fix clippy warnings #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Aug 30, 2023
fjarri
force-pushed
the
fix-clippy
branch
2 times, most recently
from
ff5dcaa to
c17f72e
Compare
tarcieri
reviewed
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bunch of clippy warnings that are raised with Rust 1.72, but do not appear in CI which uses 1.65 for clippy. Makes it easier to run clippy during development. Clippy bumped to 1.72 in CI.
I decided to go with
#![allow(clippy::unwrap_used)]for test submodules instead of replacing eachunwrap()there withexpect().