Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug builds #1081

Merged
merged 5 commits into from
Apr 2, 2021
Merged

Debug builds #1081

merged 5 commits into from
Apr 2, 2021

Conversation

waych
Copy link
Contributor

@waych waych commented Mar 26, 2021

sdl2-sys was hardcoding the bundled build as a release build,
unconditionally for a long time. This can cause problems however if an
upstream link of a binary is mixing C++ libraries that mix debug and non
debug builds, or so at least I'm led to believe for static builds.

waych and others added 5 commits March 26, 2021 15:18
sdl2-sys was hardcoding the bundled build as a release build,
unconditionally for a long time.  This can cause problems however if an
upstream link of a binary is mixing C++ libraries that mix debug and non
debug builds, or so at least I'm led to believe for static builds.
@Cobrand Cobrand merged commit e3c0658 into Rust-SDL2:master Apr 2, 2021
@waych waych deleted the debug_builds branch April 2, 2021 15:28
@Cobrand
Copy link
Member

Cobrand commented Apr 18, 2021

I think this PR caused #1088, would you mind checking it out? If you don't have time to dig into this, I will have to revert this commit temporarily until we can find a way to include SDL2 debug builds that don't break anything else.

@waych
Copy link
Contributor Author

waych commented Apr 18, 2021

Taking a look see.

@waych
Copy link
Contributor Author

waych commented Apr 18, 2021

Let's rollback. This needs more work.

It seems the use of the 'd' suffix may be tied to OS, setting it unconditionally at least doesn't seem to do the right thing in all cases.

Build works fine for me locally with both ["bundled"] and ["bundled", "static-link"], but I added Windows bundled builds to the CI in the same commit which is producing link errors even after I fixed the broken file copy. I haven't yet been able to reproduce these errors locally.

Sorry for the break :(

waych added a commit to waych/rust-sdl2 that referenced this pull request Apr 18, 2021
Broke non-"static-link" builds on Windows when using "bundled" and non
release builds.

Closes Rust-SDL2#1088
@waych
Copy link
Contributor Author

waych commented Apr 18, 2021

Oh hmm. I was testing "bundled" with ["gfx", "image", "ttf", "mixer"] set, but am realizing now that those aren't actually supported with "bundled" yet.

Cobrand pushed a commit that referenced this pull request Apr 19, 2021
Broke non-"static-link" builds on Windows when using "bundled" and non
release builds.

Closes #1088
waych added a commit to waych/rust-sdl2 that referenced this pull request Apr 19, 2021
Roll this forward again to make merge easier.
waych added a commit to waych/rust-sdl2 that referenced this pull request Apr 23, 2021
This adds back the ability to compile the debug version of SDL2 when the
cargo build is a debug build.  Previous attempt (PR Rust-SDL2#1081) broke dynamic
linking bundled builds on Windows, forgetting to copy the resulting DLL
correctly and misspecifying the name of the library in that case.
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
sdl2-sys was hardcoding the bundled build as a release build,
unconditionally for a long time.  This can cause problems however if an
upstream link of a binary is mixing C++ libraries that mix debug and non
debug builds, or so at least I'm led to believe for static builds.
sypwex pushed a commit to sypwex/rust-sdl2 that referenced this pull request Jun 2, 2024
Broke non-"static-link" builds on Windows when using "bundled" and non
release builds.

Closes Rust-SDL2#1088
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants