-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debug builds #1081
Debug builds #1081
Conversation
sdl2-sys was hardcoding the bundled build as a release build, unconditionally for a long time. This can cause problems however if an upstream link of a binary is mixing C++ libraries that mix debug and non debug builds, or so at least I'm led to believe for static builds.
I think this PR caused #1088, would you mind checking it out? If you don't have time to dig into this, I will have to revert this commit temporarily until we can find a way to include SDL2 debug builds that don't break anything else. |
Taking a look see. |
Let's rollback. This needs more work. It seems the use of the 'd' suffix may be tied to OS, setting it unconditionally at least doesn't seem to do the right thing in all cases. Build works fine for me locally with both Sorry for the break :( |
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes Rust-SDL2#1088
Oh hmm. I was testing "bundled" with |
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes #1088
Roll this forward again to make merge easier.
This adds back the ability to compile the debug version of SDL2 when the cargo build is a debug build. Previous attempt (PR Rust-SDL2#1081) broke dynamic linking bundled builds on Windows, forgetting to copy the resulting DLL correctly and misspecifying the name of the library in that case.
sdl2-sys was hardcoding the bundled build as a release build, unconditionally for a long time. This can cause problems however if an upstream link of a binary is mixing C++ libraries that mix debug and non debug builds, or so at least I'm led to believe for static builds.
Broke non-"static-link" builds on Windows when using "bundled" and non release builds. Closes Rust-SDL2#1088
sdl2-sys was hardcoding the bundled build as a release build,
unconditionally for a long time. This can cause problems however if an
upstream link of a binary is mixing C++ libraries that mix debug and non
debug builds, or so at least I'm led to believe for static builds.