Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename ControlNode to just Node. #8

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Rename ControlNode to just Node. #8

merged 2 commits into from
Nov 5, 2024

Conversation

eddyb
Copy link
Collaborator

@eddyb eddyb commented Nov 5, 2024

Follow-up to (which has some motivation and methodology):

The one notable difference is the print commit (where print::Node existed and unnecessarily conflicted with ControlNode post-rename).

@eddyb eddyb added this to the 0.5.0 milestone Nov 5, 2024
@eddyb eddyb enabled auto-merge November 5, 2024 17:17
LegNeato
LegNeato approved these changes Nov 5, 2024
View reviewed changes
Copy link
Collaborator

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@eddyb eddyb added this pull request to the merge queue Nov 5, 2024
Merged via the queue into Rust-GPU:main with commit 3cabf18 Nov 5, 2024
6 checks passed
@eddyb eddyb deleted the uncontrol-node branch November 5, 2024 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LegNeato LegNeato LegNeato approved these changes

Assignees
No one assigned
Labels
needs-changelog
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
2 participants
@eddyb @LegNeato