Remove unnecessary methods/fields of Rust::Lexer
#2347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc/rust/ChangeLog: * lex/rust-lex.cc (Lexer::build_token): Replace function call. (Lexer::parse_string): Likewise. (Lexer::parse_identifier_or_keyword): Likewise. (Lexer::parse_raw_string): Likewise. (Lexer::parse_char_or_lifetime): Likewise. (Lexer::get_input_codepoint_length): Deleted. (Lexer::peek_codepoint_input): Deleted. (Lexer::skip_codepoint_input): Deleted. * lex/rust-lex.h: Remove some methods and fields Signed-off-by: Raiki Tamura <[email protected]>
tamaroning
commented
Jun 29, 2023
Comment on lines
+2014
to
+2016
| // FIXME: should remove this but can't. | ||
| // `parse_utf8_escape` does not update `current_char` correctly. | ||
| current_char = peek_input (); |
There was a problem hiding this comment.
This line should be removed but can't.
parse_utf8_escape() seems not to update current_char properly.
tamaroning
commented
Jun 29, 2023
Comment on lines
-139
to
-142
| int get_input_codepoint_length (); | ||
| // Peeks the current utf-8 char | ||
| Codepoint peek_codepoint_input (); | ||
| void skip_codepoint_input (); |
There was a problem hiding this comment.
These functions are unnecessary so deleted in this pr(See #2307)
tamaroning
commented
Jun 29, 2023
| @@ -393,7 +389,6 @@ class Lexer | |||
| int current_column; | |||
| // Current character. | |||
| Codepoint current_char; | |||
| Codepoint current_char32; | |||
There was a problem hiding this comment.
This field was added to parse Unicode identifiers via #2284 but is unnecessary now.
|
@CohenArthur apt-get fails in CI. How can i rerun tests? |
|
@tamaroning I re-ran the CI manually. Not sure why it failed on this step, but yeah this is not your fault so don't worry :) |
CohenArthur
approved these changes
Jun 29, 2023
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #2309