Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PreRelease, and update manifest.version_name #2

Merged
merged 2 commits into from Feb 14, 2024

Conversation

RupertBarrow
Copy link
Owner

@RupertBarrow RupertBarrow commented Feb 13, 2024

Pull Request

Related issue

GabeDuarteM#111

Description

This change builds on the AllowPrerelease change requested in GabeDuarteM#111 which adapts manifest.version to the Chrome Extension version numbering scheme. This change also updates the manifest.version_name field.

Why

When building multiple successive alpha or beta prerelease versions, we want a way of knowing the build version of those releases.

How

The "standard" manifest.version_name field is updated with the original semantic-release generated version number.

How has this been tested

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • Documentation
  • Ready to be merged
  • My code follows the code style of this project (run npm run ci to be sure).
  • I have read the CONTRIBUTING document.

@RupertBarrow RupertBarrow merged commit 15cb1d7 into RupertBarrow:pr/allowPrereleaseAndVersionName Feb 14, 2024
@RupertBarrow
Copy link
Owner Author

🎉 This PR is included in version 3.3.0-prAllowPrereleaseAndVersionName.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant