Add nightmode #28
Merged
Add nightmode #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per the chat in: esphome#3886 , do you think this is OK to merge? |
RubyBailey
reviewed
Mar 6, 2024
| case MITSUBISHI_NIGHTMODE: | ||
| this->preset = climate::CLIMATE_PRESET_SLEEP; | ||
| break; | ||
| case MITSUBISHI_DEFAULTMODE: |
There was a problem hiding this comment.
Hi @OlympusMonds ,
I am OK with adding nightmode as CLIMATE_PRESET_SLEEP.
I am having a challenge with CLIMATE_PRESET_NONE. state_frame[14] and state_frame[15] are in the presets. My controls, remember mine are older units, set 0x00 in these frames. I don't think MITSUBISHI_DEFAULTMODE is a good way to evaluate that CLIMATE_PRESET_NONE is selected.
There was a problem hiding this comment.
No worries, I've removed that code, and it actually still works just fine.
There was a problem hiding this comment.
I think we’re good to merge. Thanks for working on this.
RubyBailey
merged commit 3cb1fb4
into
RubyBailey:mitsubishi-updates
32 of 35 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix?
Add support for night mode on the Mitsubishi.
I've been using your branch on my MSZ-AP units, and it's been great, thanks!
This change add support for night mode, using the climate mode SLEEP. Seems to work for me!
Types of changes