Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to rsyncd.conf from /etc to hermetic-usr pattern. #551

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

schubi2
Copy link

@schubi2 schubi2 commented Nov 29, 2023

In order to fulfill the UAPI Group Specifications regarding configuration files:
https://uapi-group.org/specifications/specs/configuration_files_specification/
we are adapting "main" packages.
Fortunately rsync has already similar way. So only few changes are needed for it :-)

@schubi2 schubi2 changed the title Moving to rsyncd.conf from /etc to /usr/etc Moving to rsyncd.conf from /etc to hermetic-usr pattern. Nov 30, 2023
Copy link
Member

@tridge tridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the fix please describe the testing you have done

config_file = RSYNCD_SYSCONF;
#ifdef RSYNCD_DISTCONF
STRUCT_STAT st;
if (do_stat(RSYNCD_SYSCONF, &st) != 0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd - do_stat() returns 0 on finding the file. So you are using the file only if it doesn't exist?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants