Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SAM 3.1.0 : Lasso model, Validators, ClipTransformer and some utils #49

Merged
merged 46 commits into from
Aug 25, 2022
Merged

SAM 3.1.0 : Lasso model, Validators, ClipTransformer and some utils #49

merged 46 commits into from
Aug 25, 2022

Conversation

abontsema
Copy link
Contributor

@abontsema abontsema commented Aug 2, 2022 •
edited
Loading

Checklist

  • unit test
  • docs
  • example
  • changelog
  • version number

@abontsema abontsema added Priority: Medium Issues that need to be fixed, but low impact or a workaround exists Type: Feature New feature requests labels Aug 2, 2022
@abontsema
Copy link
Contributor Author

Implementation of #10

@abontsema abontsema marked this pull request as ready for review August 2, 2022 15:10
@abontsema abontsema self-assigned this Aug 8, 2022
@abontsema abontsema linked an issue Aug 11, 2022 that may be closed by this pull request
LinearTimeseriesRegressor / TimeseriesLinearRegressor #10
Closed
ruudkassing
ruudkassing previously approved these changes Aug 12, 2022
View reviewed changes
Copy link
Collaborator

@ruudkassing ruudkassing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than some minor comments

sam/models/lasso_model.py Show resolved Hide resolved
sam/models/tests/test_lasso_model.py Outdated Show resolved Hide resolved
@abontsema abontsema mentioned this pull request Aug 18, 2022
Closed
@abontsema abontsema changed the title Linear model: LassoTimeseriesRegressor SAM version 3.1: Lasso model, Validator methods, ClipTransformer and some utils Aug 18, 2022
@abontsema abontsema changed the title SAM version 3.1: Lasso model, Validator methods, ClipTransformer and some utils SAM 3.1.0 : Lasso model, Validator methods, ClipTransformer and some utils Aug 18, 2022
@abontsema abontsema changed the title SAM 3.1.0 : Lasso model, Validator methods, ClipTransformer and some utils SAM 3.1.0 : Lasso model, Validators, ClipTransformer and some utils Aug 18, 2022
rubenpeters91
rubenpeters91 previously approved these changes Aug 18, 2022
View reviewed changes
@abontsema abontsema mentioned this pull request Aug 18, 2022
Open
@sbuergers sbuergers linked an issue Aug 19, 2022 that may be closed by this pull request
Refactor current validation module by adding BaseValidator class #56
Closed
rubenpeters91
rubenpeters91 previously approved these changes Aug 23, 2022
View reviewed changes
sam/preprocessing/train_test_split.py Outdated Show resolved Hide resolved
@abontsema abontsema merged commit 59e96fb into main Aug 25, 2022
@sbuergers sbuergers deleted the linear branch December 5, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rubenpeters91 rubenpeters91 rubenpeters91 approved these changes

@sbuergers sbuergers Awaiting requested review from sbuergers

@ruudkassing ruudkassing Awaiting requested review from ruudkassing

Assignees

@abontsema abontsema

Labels
Priority: Medium Issues that need to be fixed, but low impact or a workaround exists Type: Feature New feature requests
Projects
None yet
Milestone
No milestone
3 participants
@abontsema @rubenpeters91 @ruudkassing