fix(DatePicker): Fix compatibility with strict mode #3964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpveooys
added
Type: Bug
✅ Deploy Preview for storybook-navy-digital-mod-uk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This updates focus-trap and focus-trap-react to fix findDOMNode deprecation warnings from React.
This stops using the onDeactivate callback in focus-trap due to its incompatibility with strict mode: https://github.com/focus-trap/focus-trap-react?tab=readme-ov-file#%EF%B8%8F%EF%B8%8F-react-18-strict-mode-%EF%B8%8F%EF%B8%8F Instead, the click and escape callbacks are used. Additionally, the DATEPICKER_ACTION.TOGGLE_OPEN reducer action was removed as the reduce functions are called twice when strict mode is enabled, so that action doesn't work as expected. Strict mode hasn't been enabled in Storybook as there seemed to be some unrelated end-to-end tests still failing with it enabled.
jpveooys
force-pushed
the
fix/date-picker-strict-mode
branch
from
effb893 to
b5c1b3f
Compare
|
m7kvqbe1
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#3528
Overview
This:
Reason
Strict mode should be supported. (Previously the day picker would not open when strict mode is on.)
Work carried out
clickOutsideDeactivatesandescapeDeactivatesfocus-trap callbacks instead ofonDeactivateDATEPICKER_ACTION.TOGGLE_OPENreducer action (as reducer functions are called twice in strict mode)Developer notes
See https://github.com/focus-trap/focus-trap-react?tab=readme-ov-file#%EF%B8%8F%EF%B8%8F-react-18-strict-mode-%EF%B8%8F%EF%B8%8F for the react-focus-trap node about strict mode –
onDeactivatewasn't really the right callback as it gets called when the component is unmounted.Strict mode is still disabled in Storybook as there were some other unrelated failures with it on (mainly in the form usage examples).