Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of id and other attributes on TextE #3951

Merged
merged 2 commits into from
Nov 6, 2024
Merged

Conversation

thyhjwb6
Copy link
Collaborator

Related issue

NA

Overview

Allows setting of id and other attributes on the rendered element from TextE.

Reason

Primarily required for setting id in downstream app.

Work carried out

  • Refactor existing tests
  • Allow setting of attributes

@thyhjwb6 thyhjwb6 added Type: Enhancement New feature or request Package: react-component-library Package/code type labels Oct 31, 2024
@thyhjwb6 thyhjwb6 self-assigned this Oct 31, 2024
@thyhjwb6 thyhjwb6 changed the title Allow setting of id and other attributes on TextE [WIP] Allow setting of id and other attributes on TextE Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for storybook-navy-digital-mod-uk ready!

Name Link
🔨 Latest commit 396fafe
🔍 Latest deploy log https://app.netlify.com/sites/storybook-navy-digital-mod-uk/deploys/672b8149aa63b400087e3a32
😎 Deploy Preview https://deploy-preview-3951--storybook-navy-digital-mod-uk.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thyhjwb6 thyhjwb6 changed the title [WIP] Allow setting of id and other attributes on TextE Allow setting of id and other attributes on TextE Oct 31, 2024
@thyhjwb6 thyhjwb6 marked this pull request as ready for review October 31, 2024 15:46
@thyhjwb6
Copy link
Collaborator Author

thyhjwb6 commented Nov 1, 2024

I've actually made a mistake on this so will need to do a small amount of work on it today.

@thyhjwb6 thyhjwb6 changed the title Allow setting of id and other attributes on TextE [WIP] Allow setting of id and other attributes on TextE Nov 1, 2024
@thyhjwb6 thyhjwb6 changed the title [WIP] Allow setting of id and other attributes on TextE Allow setting of id and other attributes on TextE Nov 6, 2024
@thyhjwb6
Copy link
Collaborator Author

thyhjwb6 commented Nov 6, 2024

This one is ready when you are @m7kvqbe1

Copy link
Collaborator

@m7kvqbe1 m7kvqbe1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@markhigham markhigham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Nov 6, 2024

@m7kvqbe1 m7kvqbe1 merged commit c7bf839 into master Nov 6, 2024
20 checks passed
@m7kvqbe1 m7kvqbe1 deleted the feat/text-props branch November 6, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Package: react-component-library Package/code type Type: Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants