fix(Sidebar): Sidebar now overlays page content #3837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for storybook-navy-digital-mod-uk ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
will-lamb
added
Type: Bug
|
Looks like there may be a bit more to this as it's causing a layout shift. It might be the way the example is setup.
|
will-lamb
force-pushed
the
bugfix/sidebar-to-overlay-content
branch
from
391f5df to
0d56a27
Compare
fix(Sidebar): Using context to transfer isOpen prop
will-lamb
force-pushed
the
bugfix/sidebar-to-overlay-content
branch
from
0d56a27 to
ea8515f
Compare
|
m7kvqbe1
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
#3826
Overview
I have changed the display property of the sidebar to absolute when it is open so that it overlays the page content rather than pushing it to one side.
Reason
Currently, there is a layout shift happening when the sidebar is opened as it pushes the content to the right.
Work carried ou
Example.
Screenshot
Before:
After:
