Add boost_submod to tool directory scripts. #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is temporary, will remove the old 1_55 version if we merge, but they should be able to coexist for now.
lyskov
approved these changes
Nov 19, 2019
There was a problem hiding this comment.
Looks good to me Rocco! I am not sure if you want it but alternatively we use this PR https://github.com/RosettaCommons/main/pull/4231 and make this changes in-sync (but that will probably delay Boost upgrade PR merging so i am not sure if you want to that)
|
Yeah, I thought of that, but I didn't want to couple the boost submodule change with the submodularizing tools change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support full testing of RosettaCommons/main#4360, we need to have support/changes in the tools repo (for tests like the header only and serialization code quality tests, which use scripts in the tools directory which hard code the compiler include paths.)
To support both current master and the new submodule approach, I've added the boost_submod directory to the compilation command line in addition the the old boost_1_55_0 one. That should hopefully work for both versions, as nonexistant include directories should be ignored. (We can remove the old directory if/when we officially merge the submodule approach.)