Docker monitoring and clap.rs changes #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dockerfile to be sip) - Add test for container status, using tiny image (5mb) - Fix type issue with lib.rs, only applies on Unix ( cfg = unix )
- ( Docker can't have _ in container / image names )
- creates container
- creates metrics log
- starts logging
- waits 2s
- ensures there are no errors
& that there are metrics & the container_name is correct
|
closes #34 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for docker monitoring by container name
//TODO tests
@ohuu thoughts on testing by spinning up a container ?
Seems like it'll horribly slow down ci/cd ( at a later date )