Fixing bug in isPHPVersionMoreRecentThan #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… certain version threshold. This not only simplifies the function by using a native PHP method purpose built for this use case, but it also fixes a bug with the implementation. If the installed version is 8.1, and the function is called with the string 7.4, it should return true because 8.1 is more recent than 7.4. however it returns false, because the first conditional check fails, so we fall through to the second conditional (the elseif). The problem with this second conditional is that it only examines the minor version, not taking into account the major version. So in our example, it compares 1 to 4. Since 1 is less than 4, this condition succeeds, and the function returns false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the installed version is 8.1, and the function is called with the string 7.4, it should return true because 8.1 is more recent than 7.4. however it returns false, because the first conditional check fails, so we fall through to the second conditional (the elseif).
The problem with this second conditional is that it only examines the minor version, not taking into account the major version. So in our example, it compares 1 to 4. Since 1 is less than 4, this condition succeeds, and the function returns false.
This fix also simplifies the function by using a native PHP method that is purpose built for this use case