Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alex's branch to improve GGNs #3

Merged
merged 21 commits into from
May 12, 2022
Merged

Alex's branch to improve GGNs #3

merged 21 commits into from
May 12, 2022

Conversation

vict0rsch
Copy link
Collaborator

@vict0rsch vict0rsch commented Apr 27, 2022 •
edited by AlexDuvalinho
Loading

  • Create new_X files where X is an existing model class
  • Add tag embeddings
    • Same nb of dims (new_embedding_dim = embedding_dim - tag_embedding_dim)
    • Extra dimensions

@vict0rsch vict0rsch marked this pull request as draft April 27, 2022 14:22
vict0rsch
vict0rsch commented May 5, 2022
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@vict0rsch vict0rsch marked this pull request as ready for review May 12, 2022 14:00
@vict0rsch vict0rsch merged commit 8f768fb into main May 12, 2022
@vict0rsch vict0rsch deleted the gnn-improvements branch May 12, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexDuvalinho AlexDuvalinho AlexDuvalinho left review comments

@alexhernandezgarcia alexhernandezgarcia Awaiting requested review from alexhernandezgarcia

Assignees

@vict0rsch vict0rsch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vict0rsch @AlexDuvalinho