Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add French translations #2

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Add French translations #2

wants to merge 8 commits into from

Conversation

annavik
Copy link
Member

@annavik annavik commented Dec 19, 2024

In this PR we add French translations (thanks @Annie-Shan ! ⭐ ). We also add a language control to make it possible for anyone to switch language.

Summary of logic

  • We will use the browser language as the default preference, with English as the fallback value (when the browser language cannot be matched to English or French).
  • If the user changes language from top bar, we will override the browser language and store the preference in a cookie. This means next time we can present the website in the preferred language from start.

Notes

  • Do you think we should translate section "Academic Publications"? The resources we link to in this sections are all English, but we could perhaps present translated summaries?
  • Do you think we should translate the 11 items under "The AMI Initiatives"?

Screenshot

Screenshot 2024-12-19 at 13 09 46

Copy link

netlify bot commented Dec 19, 2024

Deploy Preview for ami-consortium ready!

Name Link
🔨 Latest commit e78f518
🔍 Latest deploy log https://app.netlify.com/sites/ami-consortium/deploys/6766053e0a5a3e00085fd45a
😎 Deploy Preview https://deploy-preview-2--ami-consortium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant